-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the logTimeFormat value for time formatting in the KEDA Operator #41
Conversation
Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
09a1a9c
to
d1f6d34
Compare
@tbickford thanks, this is great. Could you please open another PR in kedacore/keda repo to add this change there as well? |
We should fix this #42 before mergin this PR, to include you change to the latest v.1.4 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tbickford, though as @zroubalik mentioned lets wait on the chart version fix then take this change.
For the rest it looks good to me, thanks! |
@tbickford We provide some help with DCO issues on https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what |
f88e03b
to
fd12f44
Compare
Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
@tomkerkhove Thanks for the link. |
My pleasure, thank you! |
This allows for adjusting the
zap-time-encoding
argument to the KEDA Operator so that time formats like ISO8601 can be used. ISO8601 is more reader-friendly when examining the timestamps in the logs and possibly could be used as the default value in the values.yaml.