Adding the logTimeFormat value for time formatting in the KEDA Operator #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbickford
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
tbickford
force-pushed
the
master
branch
3 times, most recently
from
09a1a9c
to
d1f6d34
Compare
|
@tbickford thanks, this is great. Could you please open another PR in kedacore/keda repo to add this change there as well? |
|
We should fix this #42 before mergin this PR, to include you change to the latest v.1.4 release. |
ahmelsayed
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Thanks @tbickford, though as @zroubalik mentioned lets wait on the chart version fix then take this change.
tomkerkhove
requested changes
Apr 21, 2020
|
For the rest it looks good to me, thanks! |
tomkerkhove
approved these changes
Apr 21, 2020
|
@tbickford We provide some help with DCO issues on https://github.com/kedacore/keda/blob/master/CONTRIBUTING.md#i-didnt-sign-my-commit-now-what |
tbickford
force-pushed
the
master
branch
6 times, most recently
from
f88e03b
to
fd12f44
Compare
Signed-off-by: Travis Bickford <tbickford@shutterstock.com>
|
@tomkerkhove Thanks for the link. |
|
My pleasure, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for adjusting the
zap-time-encodingargument to the KEDA Operator so that time formats like ISO8601 can be used. ISO8601 is more reader-friendly when examining the timestamps in the logs and possibly could be used as the default value in the values.yaml.